linux-kernel - Re: [PATCH] arm64: dts: qcom: qcs6490-rb3gen2: Enable USB2 controller Micro-USB OTG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <y32g3rpgfjtr6qyic6goj24uw24tucdsenninqqok3r5ofahj2@7cxcwf4cn6cc>
Date: Tue, 10 Feb 2026 23:15:32 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Akash Kumar <akash.kumar@....qualcomm.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: qcs6490-rb3gen2: Enable USB2
 controller Micro-USB OTG

On Tue, Feb 10, 2026 at 08:09:26PM +0530, Akash Kumar wrote:
> Enable the secondary USB controller (USB2) and its High-Speed PHY to
> support OTG functionality via a Micro-USB connector.
> 
> Define a dedicated 'usb2-connector' node using the 'gpio-usb-b-connector'
> compatible to handle ID and VBUS detection. Link this connector to the
> DWC3 controller via OF graph ports to satisfy schema requirements and
> enable role switching.
> 
> Specific hardware configuration:
> - ID pin: TLMM 61
> - VBUS detection: PM7325 GPIO 9
> - VBUS supply: Fixed regulator controlled by TLMM 63
> - Configure &usb_2 in OTG mode with role switching enabled.
> - Define a gpio-usb-b-connector node for Micro-USB support, mapping the
>   ID pin to TLMM 61 and VBUS detection to PM7325 GPIO 9.
> - Add the 'vdd_micro_usb_vbus' fixed regulator (controlled by TLMM 63) to
>   supply VBUS to the connector.
> - Add the 'usb2_id_detect' pinctrl state to configure GPIO 61 for ID
>   detection.
> - Enable &usb_2_hsphy and populate necessary voltage supplies (VDDA PLL,
>   VDDA 1.8V, VDDA 3.3V).
> 
> Signed-off-by: Akash Kumar <akash.kumar@....qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 68 ++++++++++++++++++++
>  1 file changed, 68 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> index f29a352b0288..ee472d8b2db1 100644
> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> @@ -217,6 +217,16 @@ pmic_glink_sbu_in: endpoint {
>  		};
>  	};
>  
> +	vdd_micro_usb_vbus: regulator-micro-usb-vbus {
> +	       compatible = "regulator-fixed";
> +	       regulator-name = "MICRO_USB_VBUS";
> +	       gpio = <&tlmm 63 GPIO_ACTIVE_HIGH>;
> +	       regulator-min-microvolt = <5000000>;
> +	       regulator-max-microvolt = <5000000>;
> +	       regulator-boot-on;
> +	       enable-active-high;
> +	};
> +
>  	vph_pwr: regulator-vph-pwr {
>  		compatible = "regulator-fixed";
>  		regulator-name = "vph_pwr";
> @@ -262,6 +272,30 @@ active-config0 {
>  		};
>  	};
>  
> +	usb2-connector {
> +		compatible = "gpio-usb-b-connector",
> +			     "usb-b-connector";
> +		label = "micro-USB";
> +		type = "micro";
> +		id-gpios = <&tlmm 61 GPIO_ACTIVE_HIGH>;
> +		vbus-gpios = <&pm7325_gpios 9 GPIO_ACTIVE_HIGH>;
> +		vbus-supply = <&vdd_micro_usb_vbus>;
> +		pinctrl-0 = <&usb2_id_detect>;
> +		pinctrl-names = "default";
> +
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 {
> +				reg = <0>;
> +				usb2_connector_ep: endpoint {
> +					remote-endpoint = <&usb2_controller_ep>;
> +				};
> +			};
> +		};
> +	};
> +
>  	wcn6750-pmu {
>  		compatible = "qcom,wcn6750-pmu";
>  		pinctrl-0 = <&bt_en>;
> @@ -606,6 +640,7 @@ vreg_bob_3p296: bob {
>  			regulator-max-microvolt = <3960000>;
>  		};
>  	};
> +

Stray empty line

>  };
>  
>  &gcc {
> @@ -1137,6 +1172,12 @@ qup_uart7_sleep_tx: qup-uart7-sleep-tx-state {
>  		 */
>  		bias-pull-up;
>  	};
> +
> +	usb2_id_detect: usb2-id-detect-state {
> +		pins = "gpio61";
> +		function = "gpio";
> +		bias-pull-up;
> +	};
>  };
>  
>  &uart5 {
> @@ -1200,6 +1241,33 @@ &usb_1_qmpphy {
>  	status = "okay";
>  };
>  
> +&usb_2 {
> +	dr_mode = "otg";

This is default and can be dropped

> +	usb-role-switch;

THis should be moved to the kodiak.dtsi.

> +
> +	status = "okay";
> +
> +	ports {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		port@0 {
> +			reg = <0>;
> +			usb2_controller_ep: endpoint {
> +				remote-endpoint = <&usb2_connector_ep>;
> +			};
> +		};
> +	};
> +};
> +
> +&usb_2_hsphy {
> +	vdda-pll-supply = <&vreg_l10c_0p88>;
> +	vdda18-supply = <&vreg_l1c_1p8>;
> +	vdda33-supply = <&vreg_l2b_3p072>;
> +
> +	status = "okay";
> +};
> +
>  &usb_dp_qmpphy_out {
>  	remote-endpoint = <&redriver_phy_con_ss>;
>  };
> -- 
> 2.43.0
> 

-- 
With best wishes
Dmitry