linux-kernel - Re: [PATCH v3] staging: rtl8723bs: remove shadowed variable in sdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DGBNEW30FUI3.LOI6M3QV8OT4@gmail.com>
Date: Tue, 10 Feb 2026 16:51:36 -0600
From: "Ethan Tidmore" <ethantidmore06@...il.com>
To: "Haroen Tmimi" <tmimiharoen@...il.com>, <gregkh@...uxfoundation.org>
Cc: <linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] staging: rtl8723bs: remove shadowed variable in
 sdio_halinit

On Tue Feb 10, 2026 at 12:56 PM CST, Haroen Tmimi wrote:
> The variable 'bMacPwrCtrlOn' was redeclared in the function
> CardEnable, shadowing a variable of the same name declared at the
> top of the function (line 21).
>
> Remove the redundant 'u8' type declaration to use the existing outer
> variable and resolve a -Wshadow warning.
>
> Signed-off-by: Haroen Tmimi <tmimiharoen@...il.com>
> ---

LGTM.

Reviewed-by: Ethan Tidmore <ethantidmore06@...il.com>

Thanks,

ET