linux-kernel - RE: [PATCH net-next v12 3/5] eth fbnic: Add msix self test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR11MB75889BAC137B53534428EB87D662A@PH0PR11MB7588.namprd11.prod.outlook.com>
Date: Tue, 10 Feb 2026 22:55:39 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: Paolo Abeni <pabeni@...hat.com>, "mike.marciniszyn@...il.com"
	<mike.marciniszyn@...il.com>, Alexander Duyck <alexanderduyck@...com>, "Jakub
 Kicinski" <kuba@...nel.org>, "kernel-team@...a.com" <kernel-team@...a.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Simon Horman <horms@...nel.org>, "Russell
 King" <linux@...linux.org.uk>, Mohsin Bashir <mohsin.bashr@...il.com>, "Lee
 Trager" <lee@...ger.us>, Dan Carpenter <dan.carpenter@...aro.org>, Pei Xiao
	<xiaopei01@...inos.cn>, Stanislav Fomichev <sdf@...ichev.me>, "Kuniyuki
 Iwashima" <kuniyu@...gle.com>, Samiullah Khawaja <skhawaja@...gle.com>, Ahmed
 Zaki <ahmed.zaki@...el.com>, "Lobakin, Aleksander"
	<aleksander.lobakin@...el.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next v12 3/5] eth fbnic: Add msix self test



> -----Original Message-----
> From: Paolo Abeni <pabeni@...hat.com>
> Sent: Tuesday, February 10, 2026 7:06 AM
> To: mike.marciniszyn@...il.com; Alexander Duyck
> <alexanderduyck@...com>; Jakub Kicinski <kuba@...nel.org>; kernel-
> team@...a.com; Andrew Lunn <andrew+netdev@...n.ch>; David S. Miller
> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Simon
> Horman <horms@...nel.org>; Russell King <linux@...linux.org.uk>; Keller,
> Jacob E <jacob.e.keller@...el.com>; Mohsin Bashir
> <mohsin.bashr@...il.com>; Lee Trager <lee@...ger.us>; Dan Carpenter
> <dan.carpenter@...aro.org>; Pei Xiao <xiaopei01@...inos.cn>; Stanislav
> Fomichev <sdf@...ichev.me>; Kuniyuki Iwashima <kuniyu@...gle.com>;
> Samiullah Khawaja <skhawaja@...gle.com>; Ahmed Zaki
> <ahmed.zaki@...el.com>; Lobakin, Aleksander
> <aleksander.lobakin@...el.com>
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH net-next v12 3/5] eth fbnic: Add msix self test
> 
> On 2/6/26 4:42 PM, mike.marciniszyn@...il.com wrote:
> > +/**
> > + * fbnic_msix_test - Verify behavior of NIC interrupts
> > + * @fbd: device to test
> > + *
> > + * This function is meant to test the global interrupt registers and the
> > + * PCIe IP MSI-X functionality. It essentially goes through and tests
> > + * test various combinations of the set, clear, and mask bits in order to
> > + * verify the behavior is as we expect it to be from the driver.
> > + *
> > + * Return: non-zero on failure.
> > + **/
> > +int fbnic_msix_test(struct fbnic_dev *fbd)
> > +{
> > +	struct pci_dev *pdev = to_pci_dev(fbd->dev);
> > +	struct fbnic_msix_test_data *test_data;
> > +	int result = 0;
> > +	u32 mask = 0;
> > +	int i;
> > +
> > +	/* Allocate bitmap and IRQ vector table */
> > +	test_data = kzalloc(sizeof(*test_data), GFP_KERNEL);
> > +
> > +	/* Result = 5 for memory allocation failure */
> > +	if (!test_data)
> > +		return 5;
> 
> Instead of magic numbers you could define some macros, or simply return
> a boolean success/failures value (as the caller ignores the error code).
> 
> /P

At least use -ENOMEM or something....