linux-kernel - Re: [PATCH 3/6] x86/microcode: Refactor platform ID enumeration into a helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b507e2f4-acf0-4419-8802-d086c0b4872d@intel.com>
Date: Tue, 10 Feb 2026 15:23:23 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: Sohil Mehta <sohil.mehta@...el.com>,
 Dave Hansen <dave.hansen@...ux.intel.com>, linux-kernel@...r.kernel.org
Cc: zhao1.liu@...el.com, Borislav Petkov <bp@...en8.de>,
 "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
 Jon Kohler <jon@...anix.com>, Pawan Gupta
 <pawan.kumar.gupta@...ux.intel.com>,
 "Peter Zijlstra (Intel)" <peterz@...radead.org>,
 Thomas Gleixner <tglx@...nel.org>, Tony Luck <tony.luck@...el.com>,
 x86@...nel.org
Subject: Re: [PATCH 3/6] x86/microcode: Refactor platform ID enumeration into
 a helper

On 2/10/26 15:20, Sohil Mehta wrote:
> Reviewed-by: Sohil Mehta <sohil.mehta@...el.com>

Thanks!

> A minor nit:
> 
>> -	if (IFM(x86_family(sig->sig), x86_model(sig->sig)) >= INTEL_PENTIUM_III_DESCHUTES) {
>> -		unsigned int val[2];
>> -
>> -		/* get processor flags from MSR 0x17 */
>> -		native_rdmsr(MSR_IA32_PLATFORM_ID, val[0], val[1]);
>> -		sig->pf = 1 << ((val[1] >> 18) & 7);
>> -	}
>> +	sig->pf  = 1 << intel_get_platform_id();
> How about BIT(intel_get_platform_id())?

... and ack on that. I may fix it at application.