linux-kernel - Re: [PATCH 1/6] x86/cpu: Break Vendor/Family/Model macros into separate header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYvAB10SyKs17XiS@agluck-desk3>
Date: Tue, 10 Feb 2026 15:32:23 -0800
From: "Luck, Tony" <tony.luck@...el.com>
To: Sohil Mehta <sohil.mehta@...el.com>
CC: Dave Hansen <dave.hansen@...el.com>, Dave Hansen
	<dave.hansen@...ux.intel.com>, <zhao1.liu@...el.com>, Borislav Petkov
	<bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar
	<mingo@...hat.com>, Jon Kohler <jon@...anix.com>, Pawan Gupta
	<pawan.kumar.gupta@...ux.intel.com>, "Peter Zijlstra (Intel)"
	<peterz@...radead.org>, Thomas Gleixner <tglx@...nel.org>, <x86@...nel.org>,
	Iwona Winiarska <iwona.winiarska@...el.com>, LKML
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/6] x86/cpu: Break Vendor/Family/Model macros into
 separate header

On Tue, Feb 10, 2026 at 03:03:18PM -0800, Sohil Mehta wrote:
> On 2/10/2026 2:17 PM, Dave Hansen wrote:
> 
> > The reality is that we have non-x86 code using an x86 header. That's
> > crazy and it's very very unusual and we're probably going to keep
> > accidentally breaking it.

Maybe the answer is to change the peci code to not do that crazy
include of an arch/x86 file and simply have its own copies of the
#define model numbers for the eight models it cares about?

If they add a ninth at some point, they have to change their code
anyway to add a "case INTEL_FOO:". So adding the model number to
their own local include file doesn't seem like much extra work.

-Tony