linux-kernel - Re: [PATCH] rust_binder: fix oneway spam detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72nU1rUrxfAZUMeOF70gwvTPqo6Wcv6VUqYZ6mCPpyY=JQ@mail.gmail.com>
Date: Wed, 11 Feb 2026 00:55:19 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Carlos Llamas <cmllamas@...gle.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Arve Hjønnevåg <arve@...roid.com>, 
	Todd Kjos <tkjos@...roid.com>, Christian Brauner <brauner@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Wedson Almeida Filho <wedsonaf@...il.com>, 
	Matt Gilbride <mattgilbride@...gle.com>, Paul Moore <paul@...l-moore.com>, 
	Vitaly Wool <vitaly.wool@...sulko.se>, Miguel Ojeda <ojeda@...nel.org>, kernel-team@...roid.com, 
	linux-kernel@...r.kernel.org, Tiffany Yang <ynaffit@...gle.com>, stable@...r.kernel.org, 
	rust-for-linux <rust-for-linux@...r.kernel.org>
Subject: Re: [PATCH] rust_binder: fix oneway spam detection

On Wed, Feb 11, 2026 at 12:30 AM Carlos Llamas <cmllamas@...gle.com> wrote:
>
> The spam detection logic in TreeRange was executed before the current
> request was inserted into the tree. So the new request was not being
> factored in the spam calculation. Fix this by moving the logic after
> the new range has been inserted.
>
> Also, the detection logic for ArrayRange was missing altogether which
> meant large spamming transactions could get away without being detected.
> Fix this by implementing an equivalent low_oneway_space() in ArrayRange.
>
> Note that I looked into centralizing this logic in RangeAllocator but
> iterating through 'state' and 'size' got a bit too complicated (for me)
> and I abandoned this effort.
>
> Cc: stable@...r.kernel.org
> Cc: Alice Ryhl <aliceryhl@...gle.com>
> Fixes: eafedbc7c050 ("rust_binder: add Rust Binder driver")
> Signed-off-by: Carlos Llamas <cmllamas@...gle.com>

Cc'ing rust-for-linux (we still do our best to send all Rust-related
patches there too, to have an index).

Cheers,
Miguel