[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <35B721E4-F950-4425-AFF8-D6DBF54F513F@gmail.com>
Date: Tue, 10 Feb 2026 07:08:58 +0200
From: Svyatoslav Ryhel <clamor95@...il.com>
To: Rob Herring <robh@...nel.org>
CC: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>, Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>,
Jonas Schwöbel <jonasschwoebel@...oo.de>,
linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/5] ASoC: dt-bindings: nvidia,tegra-audio: document CPCAP CODEC
10 лютого 2026 р. 04:46:19 GMT+02:00, Rob Herring <robh@...nel.org> пише:
>On Fri, Feb 06, 2026 at 07:34:18PM +0200, Svyatoslav Ryhel wrote:
>> Add dt-binding for CPCAP CODEC.
>>
>> Signed-off-by: Svyatoslav Ryhel <clamor95@...il.com>
>> ---
>> .../sound/nvidia,tegra-audio-cpcap.yaml | 90 +++++++++++++++++++
>> 1 file changed, 90 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra-audio-cpcap.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-cpcap.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-cpcap.yaml
>> new file mode 100644
>> index 000000000000..5335fa56fb3c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-cpcap.yaml
>> @@ -0,0 +1,90 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/sound/nvidia,tegra-audio-cpcap.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: NVIDIA Tegra audio complex with CPCAP CODEC
>> +
>> +maintainers:
>> + - Svyatoslav Ryhel <clamor95@...il.com>
>> +
>> +allOf:
>> + - $ref: nvidia,tegra-audio-common.yaml#
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - pattern: '^[a-z0-9]+,tegra-audio-cpcap(-[a-z0-9]+)+$'
>
>Expecting a lot of devices and differences? I would assume all known h/w
>is well known and any differences are known by now. Perhaps even just
>the fallback is sufficient?
>
From 3 to 5, maybe more. Hard to trach different variations. Having no full schematic does not help either.
>> + - const: nvidia,tegra-audio-cpcap
>> +
>
>> + - |
>> + #include <dt-bindings/clock/tegra20-car.h>
>> + #include <dt-bindings/soc/tegra-pmc.h>
>> + sound {
>> + compatible = "motorola,tegra-audio-cpcap-mot",
>
>Why do we need motorola twice?
>
"Motorola" is the vendor, "mot" is the board name. Same name you have recently seen in the CPCAP schema patches I have sent.
>> + "nvidia,tegra-audio-cpcap";
>> + nvidia,model = "Motorola Atrix 4G (MB860) CPCAP";
>> +
>> + nvidia,audio-routing =
>> + "Headphones", "HSR",
>> + "Headphones", "HSL",
>> + "Int Spk", "SPKR",
>> + "Int Spk", "SPKL",
>> + "Earpiece", "EP",
>> + "HSMIC", "Mic Jack",
>> + "MICR", "Internal Mic 1",
>> + "MICL", "Internal Mic 2";
>> +
>> + nvidia,i2s-controller = <&tegra_i2s1>;
>> + nvidia,audio-codec = <&cpcap_audio>;
>> +
>> + clocks = <&tegra_car TEGRA20_CLK_PLL_A>,
>> + <&tegra_car TEGRA20_CLK_PLL_A_OUT0>,
>> + <&tegra_car TEGRA20_CLK_CDEV1>;
>> + clock-names = "pll_a", "pll_a_out0", "mclk";
>> + };
>> --
>> 2.51.0
>>
Powered by blists - more mailing lists