linux-kernel - Re: [PATCH 1/2] dt-bindings: phy: spacemit: add regulator support to K1 USB2 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20260210070009.46040-1-amadeus@jmu.edu.cn>
Date: Tue, 10 Feb 2026 15:00:09 +0800
From: Chukun Pan <amadeus@....edu.cn>
To: huang.ze@...ux.dev
Cc: amadeus@....edu.cn,
	broonie@...nel.org,
	conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	dlan@...nel.org,
	krzk+dt@...nel.org,
	krzk@...nel.org,
	lgirdwood@...il.com,
	linux-kernel@...r.kernel.org,
	linux-phy@...ts.infradead.org,
	linux-riscv@...ts.infradead.org,
	neil.armstrong@...aro.org,
	robh@...nel.org,
	spacemit@...ts.linux.dev,
	vkoul@...nel.org
Subject: Re: [PATCH 1/2] dt-bindings: phy: spacemit: add regulator support to K1 USB2 PHY

Hi,

> > It appears Ze Huang described the vbus-supply property in
> > spacemit.k1-dwc3.yaml.
> >
> > So I should enable the regulator in the dwc3-generic-plat driver.
>
> No, we will enable regulator at port level.

Since dt-bindings (spacemit.k1-dwc3.yaml) already describes the
vbus-supply property, why can't it be implemented in the dwc3 driver?

> Previously, the VBUS regulator was defined as regulator-always-on
> in the device tree as a workaround.

I don't like this workaround because we can control the VBUS regulator
through the USB PHY driver or the USB Controller driver. These are widely
implemented in other similar drivers.

Regarding port level, few manufacturers use different VBUS supplies
for the ports coming out of the USB hub, such as the ArmSoM Sige1 board.
Most boards use the same VBUS for a single USB socket, so I don't quite
understand why we need to wait for port level implementation.

Thanks,
Chukun