linux-kernel - Re: [PATCH 2/7] soc: st: add RISAB dump debug driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbdea2e7-a419-483f-8d2a-f0d045737feb@kernel.org>
Date: Tue, 10 Feb 2026 08:50:03 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Gatien Chevallier <gatien.chevallier@...s.st.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>
Cc: devicetree@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Theo GOUREAU <theo.goureau-ext@...com>
Subject: Re: [PATCH 2/7] soc: st: add RISAB dump debug driver

On 09/02/2026 15:59, Gatien Chevallier wrote:
> +
> +static int stm32_risab_register_debugfs(struct risab_pdata *pdata)
> +{
> +	struct dentry *root = NULL;
> +
> +	root = debugfs_lookup("stm32_firewall", NULL);
> +	if (!root)
> +		root = debugfs_create_dir("stm32_firewall", NULL);
> +
> +	if (IS_ERR(root))
> +		return PTR_ERR(root);
> +
> +	pdata->dbg_entry = debugfs_create_file(dev_name(pdata->dev), 0444,
> +					       root, pdata, &stm32_risab_conf_dump_fops);

soc drivers should not have any user-space interfaces. This was
requested by Arnd many times in the past, nothing new, including about
debugfs. Otherwise it opens cans of worms, because soc platform
maintainer can dump here whatever the subsystem rejected.

Find suitable subsystem and get its approval for such debugfs entry.

Your commit msg is so vague it is another reason this is not mergeable.
Explains nothing about the feature, nothing about the risk or impact on
the system when user does (while (1); read stm32_risab_conf_dump_fops).

Not mentioning that it does not explain WHY do we want this driver in
the first place...

Best regards,
Krzysztof