linux-kernel - Re: [PATCH v2 1/3] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260210082612.3xakor2yo4h3dbra@hu-kotarake-hyd.qualcomm.com>
Date: Tue, 10 Feb 2026 13:56:12 +0530
From: Rakesh Kota <rakesh.kota@....qualcomm.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Sebastian Reichel <sre@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, Vinod Koul <vkoul@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Courtney Cavin <courtney.cavin@...ymobile.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-input@...r.kernel.org,
        Rakesh Kota <rakesh.kota@....qualcomm.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: power: reset: qcom-pon: Add new
 compatible PMM8654AU

On Mon, Feb 09, 2026 at 02:49:24PM +0100, Krzysztof Kozlowski wrote:
> On 09/02/2026 14:23, Rakesh Kota wrote:
> > Add the compatible string "qcom,pmm8654au-pon" for the PMM8654AU PMIC.
> > The PON peripheral on PMM8654AU is compatible with PMK8350, so it is
> > documented as a fallback to "qcom,pmk8350-pon".
> 
> Drop everything after ,. Do not explain WHAT you did. We see it.
> 
> > 
> > While PMM8654AU supports additional registers compared to the baseline,
> 
> full stop.
> 
> > there is currently no active use case for these features. This specific
> > compatible string reserves the identifier for future hardware-specific
> > handling if required.
>
> All the rest is irrelevant or even wrong. We do not reserve identifiers.
> If you want to reserve something, then I need to reject the patch.
>
Hi Konrad Dybcio,

It appears that Krzysztof Kozlowski has concerns regarding the
compatible string reservation for future use cases, noting that
identifiers should not be reserved in this manner.

So, could you please help ACK my first patch-set instead?
https://lore.kernel.org/all/20260122-add_pwrkey_and_resin-v1-1-a9fe87537816@oss.qualcomm.com/

Best regards
Rakesh Kota
> > 
> > Signed-off-by: Rakesh Kota <rakesh.kota@....qualcomm.com>
> > ---
> 
> Where is the changelog? Nothing in cover letter explained what was
> happening with this patch, nothing is here.
> 
> >  .../devicetree/bindings/power/reset/qcom,pon.yaml        | 16 ++++++++++------
> >  1 file changed, 10 insertions(+), 6 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> > index 979a377cb4ffd577bfa51b9a3cd089acc202de0c..14b85b0d97da12c756cfe2ce33853501ba4ca46c 100644
> > --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> > +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> > @@ -17,12 +17,16 @@ description: |
> >  
> >  properties:
> >    compatible:
> > -    enum:
> > -      - qcom,pm8916-pon
> > -      - qcom,pm8941-pon
> > -      - qcom,pms405-pon
> > -      - qcom,pm8998-pon
> > -      - qcom,pmk8350-pon
> > +    oneOf:
> > +      - enum:
> > +          - qcom,pm8916-pon
> > +          - qcom,pm8941-pon
> > +          - qcom,pms405-pon
> > +          - qcom,pm8998-pon
> 
> Move this one up to to fix sorting while at it.
> 
> > +          - qcom,pmk8350-pon
> 
> And this above pms.
> 
> > +      - items:
> > +          - const: qcom,pmm8654au-pon
> > +          - const: qcom,pmk8350-pon
> 
> Best regards,
> Krzysztof