linux-kernel - Re: [PATCH 1/2] regulator: s2mps11: drop redundant sanity checks in s2mpg10_of_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ee40d36397bfd4c04aea6ead07e42848203e9d6.camel@linaro.org>
Date: Tue, 10 Feb 2026 09:37:59 +0000
From: André Draszik <andre.draszik@...aro.org>
To: Krzysztof Kozlowski <krzk@...nel.org>, Liam Girdwood
 <lgirdwood@...il.com>,  Mark Brown <broonie@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org, Dan
 Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH 1/2] regulator: s2mps11: drop redundant sanity checks in
 s2mpg10_of_parse_cb()

Hi Krzysztof,

On Tue, 2026-02-10 at 08:28 +0100, Krzysztof Kozlowski wrote:
> On 10/02/2026 06:59, André Draszik wrote:
> > Hi Krzysztof,
> > 
> > On Mon, 2026-02-09 at 17:09 +0100, Krzysztof Kozlowski wrote:
> > > On 09/02/2026 16:07, André Draszik wrote:
> > > > The sanity checks being removed in this commit are useless as earlier
> > > > code checks for out-of-bounds conditions already. They also are
> > > > incorrect (as they're off-by-one).
> > > > 
> > > > Simply remove this incorrect code.
> > > > 
> > > > No functional change.
> > > 
> > > If they are incorrect then how it could be "no functional change"? To me
> > > original code looks buggy and this is a fix. Fix must have functional
> > > change...
> > 
> > Earlier code already checks for all conditions, including all error cases.
> > So the code being removed here has no effect, as any potential error it
> > could catch will already have been caught by earlier code. Removing it
> > therefore doesn't change behaviour or functionality.
> > 
> > I can reword to 'incomplete test' instead of 'incorrect code' if you think
> > that's more clear?
> 
> Perhaps you should mention which "one" in off-by-one that it has no impact.

OK.

> I also wonder why you left the second - ext_control_s2mpg11 - untouched.

Could you point me to it please? I'm not sure I see what you mean.

Cheers,
Andre'