linux-kernel - [PATCH] scsi: qla2xxx: Completely fix fcport double free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <aYsDln9NFQQsPDgg@vova-pc>
Date: Tue, 10 Feb 2026 11:08:22 +0100
From: Vladimir Riabchun <ferr.lambarginio@...il.com>
To: njavali@...vell.com
Cc: GR-QLogic-Storage-Upstream@...vell.com,
	James.Bottomley@...senpartnership.com, martin.petersen@...cle.com,
	skashyap@...vell.com, himanshu.madhani@...cle.com,
	qutran@...vell.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] scsi: qla2xxx: Completely fix fcport double free

In qla24xx_els_dcmd_iocb sp->free is set to qla2x00_els_dcmd_sp_free.
When an error happens, this function is called by qla2x00_sp_release,
when kref_put releases the first and the last reference.

qla2x00_els_dcmd_sp_free frees fcport by calling qla2x00_free_fcport.
Doing it one more time after kref_put is a bad idea.

Fixes: 82f522ae0d97 ("scsi: qla2xxx: Fix double free of fcport")
Fixes: 4895009c4bb7 ("scsi: qla2xxx: Prevent command send on chip reset")
Signed-off-by: Vladimir Riabchun <ferr.lambarginio@...il.com>
Signed-off-by: Farhat Abbas <fabbas@...udlinux.com>
---
 drivers/scsi/qla2xxx/qla_iocb.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
index 3224044f1775..0de015de7eb5 100644
--- a/drivers/scsi/qla2xxx/qla_iocb.c
+++ b/drivers/scsi/qla2xxx/qla_iocb.c
@@ -2751,7 +2751,6 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_opcode,
 	if (!elsio->u.els_logo.els_logo_pyld) {
 		/* ref: INIT */
 		kref_put(&sp->cmd_kref, qla2x00_sp_release);
-		qla2x00_free_fcport(fcport);
 		return QLA_FUNCTION_FAILED;
 	}
 
@@ -2776,7 +2775,6 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_opcode,
 	if (rval != QLA_SUCCESS) {
 		/* ref: INIT */
 		kref_put(&sp->cmd_kref, qla2x00_sp_release);
-		qla2x00_free_fcport(fcport);
 		return QLA_FUNCTION_FAILED;
 	}
 
-- 
2.43.0