linux-kernel - Re: [PATCH] drm/imagination: Fix ROGUE_MAX_COMPUTE_SHARED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8a5de9ce32def5c33418c76ae2548f21b7d9ba7a.camel@imgtec.com>
Date: Tue, 10 Feb 2026 10:33:13 +0000
From: Frank Binns <Frank.Binns@...tec.com>
To: Matt Coster <Matt.Coster@...tec.com>,
        "maarten.lankhorst@...ux.intel.com"
	<maarten.lankhorst@...ux.intel.com>,
        "mripard@...nel.org"
	<mripard@...nel.org>,
        "airlied@...il.com" <airlied@...il.com>,
        "tzimmermann@...e.de" <tzimmermann@...e.de>,
        "simona@...ll.ch"
	<simona@...ll.ch>
CC: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Brajesh Gupta
	<Brajesh.Gupta@...tec.com>,
        Alexandru Dadu <Alexandru.Dadu@...tec.com>,
        Simon
 Perretta <Simon.Perretta@...tec.com>,
        Alessio Belle
	<Alessio.Belle@...tec.com>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/imagination: Fix ROGUE_MAX_COMPUTE_SHARED_REGISTERS

On Fri, 2026-02-06 at 09:59 +0000, Matt Coster wrote:
> Remove a spurious 2x multiplier from this def which can cause instability
> in larger compute workloads on hardware with enhancement 38020 present.
> 
> Fixes: b41ae495207e ("drm/imagination: Add GPU register headers")
> Cc: stable@...r.kernel.org
> Suggested-by: Simon Perretta <simon.perretta@...tec.com>
> Signed-off-by: Matt Coster <matt.coster@...tec.com>

Reviewed-by: Frank Binns <frank.binns@...tec.com>

> ---
>  drivers/gpu/drm/imagination/pvr_rogue_defs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/imagination/pvr_rogue_defs.h b/drivers/gpu/drm/imagination/pvr_rogue_defs.h
> index 932b01686008..1fde3be43afe 100644
> --- a/drivers/gpu/drm/imagination/pvr_rogue_defs.h
> +++ b/drivers/gpu/drm/imagination/pvr_rogue_defs.h
> @@ -114,7 +114,7 @@
>  	ROGUE_CR_FWCORE_ADDR_REMAP_CONFIG0_CBASE_CLRMSK
>  #define FWCORE_ADDR_REMAP_CONFIG0_SIZE_ALIGNSHIFT (12U)
>  
> -#define ROGUE_MAX_COMPUTE_SHARED_REGISTERS (2 * 1024)
> +#define ROGUE_MAX_COMPUTE_SHARED_REGISTERS 1024
>  #define ROGUE_MAX_VERTEX_SHARED_REGISTERS 1024
>  #define ROGUE_MAX_PIXEL_SHARED_REGISTERS 1024
>  #define ROGUE_CSRM_LINE_SIZE_IN_DWORDS (64 * 4 * 4)
> 
> ---
> base-commit: 5023ca80f9589295cb60735016e39fc5cc714243
> change-id: 20260130-rogue-max-compute-shared-registers-fffe1e714773
>