linux-kernel - Re: [PATCH 2/8] dt-bindings: interrupt-controller: add LS7A PCH LPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H5foQQFakDCYRDSM3vePZh-kECpTM+rwvs3jBvLgsjChQ@mail.gmail.com>
Date: Tue, 10 Feb 2026 20:47:17 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Icenowy Zheng <zhengxingda@...as.ac.cn>
Cc: Rob Herring <robh@...nel.org>, Thomas Gleixner <tglx@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Jiaxun Yang <jiaxun.yang@...goat.com>, 
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-mips@...r.kernel.org
Subject: Re: [PATCH 2/8] dt-bindings: interrupt-controller: add LS7A PCH LPC

On Tue, Feb 10, 2026 at 6:51 PM Icenowy Zheng <zhengxingda@...as.ac.cn> wrote:
>
> 在 2026-02-09星期一的 17:48 -0600，Rob Herring写道：
> > On Sat, Jan 31, 2026 at 05:45:41PM +0800, Icenowy Zheng wrote:
> > > Loongson 7A series PCH contains an LPC controller with an interrupt
> > > controller.
> > >
> > > Add the device tree binding for the interrupt controller.
> > >
> > > Signed-off-by: Icenowy Zheng <zhengxingda@...as.ac.cn>
> > > ---
> > >  .../loongson,pch-lpc.yaml                     | 52
> > > +++++++++++++++++++
> > >  1 file changed, 52 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/interrupt-
> > > controller/loongson,pch-lpc.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/interrupt-
> > > controller/loongson,pch-lpc.yaml
> > > b/Documentation/devicetree/bindings/interrupt-
> > > controller/loongson,pch-lpc.yaml
> > > new file mode 100644
> > > index 0000000000000..c00fbf31f47f0
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/interrupt-
> > > controller/loongson,pch-lpc.yaml
> > > @@ -0,0 +1,52 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id:
> > > http://devicetree.org/schemas/interrupt-controller/loongson,pch-lpc.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Loongson PCH LPC Controller
> > > +
> > > +maintainers:
> > > +  - Jiaxun Yang <jiaxun.yang@...goat.com>
> > > +
> > > +description:
> > > +  This interrupt controller is found in the Loongson LS7A family
> > > of PCH for
> > > +  accepting interrupts sent by LPC-connected peripherals and
> > > signalling PIC
> > > +  via a single interrupt line when interrupts are available.
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: loongson,pch-lpc-1.0
> >
> > Where does 1.0 come from? We don't do version numbers generally
> > unless
> > you define where the versions come from (e.g. Soft IP releases for
> > FPGAs). I would have expected "ls7a" in the compatible instead.
>
> I originally followed the behavior of PCH PIC; however after asking
> Jiaxun offlist, I was noticed about a register on the 7A1000 user
> manual in the PIC that identifies the PIC version number; such version
> number register does not exist for LPC part.
>
> I will switch to ls7a-lpc or ls7a1000-lpc. Newer compatible strings in
> the 2K series (LoongArch ones) come with the whole model number, I
> don't know whether this is needed for 7A1000 (although it looks like
> that 7A2000 has the same
Yes, they are the same, so I think ls7a-lpc is just OK.

Huacai

> >
> > Rob
> >
>