linux-kernel - Re: [PATCH next] mux: fix build-error when mux-core is built as module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFpV9wpcZy4kOyjz8tCiLd2bWu6ozVb80_24+HzFFX0Mjw@mail.gmail.com>
Date: Tue, 10 Feb 2026 14:36:32 +0100
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Peter Rosin <peda@...ntia.se>, Josua Mayer <josua@...id-run.com>
Cc: Wolfram Sang <wsa+renesas@...g-engineering.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH next] mux: fix build-error when mux-core is built as module

On Mon, 9 Feb 2026 at 12:24, Josua Mayer <josua@...id-run.com> wrote:
>
> The mux core header file uses ifdef CONFIG_MULTIPLEXER to select between
> helper function prototypes and static inline stubs.
>
> This leads to build errors when CONFIG_MULTIPLEXER=m, because then
> CONFIG_MULTIPLEXER_MODULE is defined instead.
>
> Replace the ifdef with IS_ENABLED to catch both builtin and module
> cases, and fix the build error in module case.
>
> Fixes: ad314348ceb4 ("mux: Add helper functions for getting optional and selected mux-state")
> Signed-off-by: Josua Mayer <josua@...id-run.com>

Peter, do you intend to pick this up as a fix for v7.0-rc1? Otherwise,
I am of course happy to help with it!

Kind regards
Uffe

> ---
>  include/linux/mux/consumer.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mux/consumer.h b/include/linux/mux/consumer.h
> index 3ede55b907eb..a961861a503b 100644
> --- a/include/linux/mux/consumer.h
> +++ b/include/linux/mux/consumer.h
> @@ -16,7 +16,7 @@ struct device;
>  struct mux_control;
>  struct mux_state;
>
> -#ifdef CONFIG_MULTIPLEXER
> +#if IS_ENABLED(CONFIG_MULTIPLEXER)
>
>  unsigned int mux_control_states(struct mux_control *mux);
>  int __must_check mux_control_select_delay(struct mux_control *mux,
>
> ---
> base-commit: 13dc45d829d5ae06f6eee3fbd3cd1f6818c08e48
> change-id: 20260209-rz-sdio-mux-fix-e8fa9c62ff95
>
> Best regards,
> --
> Josua Mayer <josua@...id-run.com>
>
>