linux-kernel - Re: [PATCH] usb: isp1760: Add missing error check for platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3de6c9bd-35c5-45c5-874b-75c6623bd4ad@gmail.com>
Date: Tue, 10 Feb 2026 16:45:45 +0300
From: Sergey Shtylyov <sergei.shtylyov@...il.com>
To: Chen Ni <nichen@...as.ac.cn>, rui.silva@...aro.org,
 gregkh@...uxfoundation.org, laurent.pinchart@...asonboard.com, balbi@...com
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: isp1760: Add missing error check for
 platform_get_resource()

On 2/10/26 12:02 PM, Chen Ni wrote:

> Check the return value of platform_get_resource() to prevent potential
> NULL pointer dereference when the memory resource is unavailable.
> 
> Fixes: 7ef077a8ad35 ("usb: isp1760: Move driver from drivers/usb/host/ to drivers/usb/isp1760/")
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  drivers/usb/isp1760/isp1760-if.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/isp1760/isp1760-if.c b/drivers/usb/isp1760/isp1760-if.c
> index a64190addba6..60f81ec81373 100644
> --- a/drivers/usb/isp1760/isp1760-if.c
> +++ b/drivers/usb/isp1760/isp1760-if.c
> @@ -196,6 +196,8 @@ static int isp1760_plat_probe(struct platform_device *pdev)
>  	int ret;
>  
>  	mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!mem_res)
> +		return -EINVAL;

   Isn't it already checked in __devm_ioremap_resource(), called later on?

[...]

MBR, Sergey