linux-kernel - Re: [PATCHv2 bpf-next 5/5] selftests/bpf: Add usdt trigger bench

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <aab191dcc7036e9ee105171cb4414df51c2ac0593daffff06c00e484b89c48b0@mail.kernel.org>
Date: Tue, 10 Feb 2026 14:12:11 +0000 (UTC)
From: bot+bpf-ci@...nel.org
To: jolsa@...nel.org,andrii@...nel.org
Cc: bpf@...r.kernel.org,linux-kernel@...r.kernel.org,songliubraving@...com,yhs@...com,john.fastabend@...il.com,ast@...nel.org,andrii@...nel.org,daniel@...earbox.net,martin.lau@...nel.org,eddyz87@...il.com,yonghong.song@...ux.dev,clm@...a.com,ihor.solodrai@...ux.dev
Subject: Re: [PATCHv2 bpf-next 5/5] selftests/bpf: Add usdt trigger bench

> diff --git a/tools/testing/selftests/bpf/progs/trigger_bench.c b/tools/testing/selftests/bpf/progs/trigger_bench.c
> index 4ea0422d1042..f631706bbdc9 100644

[ ... ]

> @@ -180,3 +181,10 @@ int bench_trigger_rawtp(void *ctx)
>  	handle(ctx);
>  	return 0;
>  }
> +
> +SEC("usdt")
> +int bench_trigger_usdt(void *ctx)

Should this use SEC("?usdt") instead of SEC("usdt")?

All other programs in this file use the '?' prefix to disable autoload by
default:

    SEC("?uprobe")
    SEC("?uprobe.multi")
    SEC("?raw_tp")
    SEC("?kprobe/bpf_get_numa_node_id")
    ...

Without the '?' prefix, bench_trigger_usdt will be auto-loaded whenever the
trigger_bench skeleton is loaded by any benchmark using setup_ctx()/load_ctx(),
adding unnecessary overhead to unrelated benchmarks.

> +{
> +	inc_counter();
> +	return 0;
> +}

---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/21867569087

AI-authorship-score: low
AI-authorship-explanation: The commit exhibits natural kernel developer style with real benchmark data, informal comments, and follows existing codebase patterns with minor inconsistencies typical of human development.
issues-found: 1
issue-severity-score: low
issue-severity-explanation: Minor pattern inconsistency in test code where SEC("usdt") should use SEC("?usdt") to match the established convention for disabling autoload by default.