linux-kernel - Re: [PATCHv2 bpf-next 4/5] selftests/bpf: Add test for checking correct nop of optimized usdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <189eab8445c1c9fa3b7e4c6dde23b4a30dc7f63ed2d3df62a1f8c889280f5927@mail.kernel.org>
Date: Tue, 10 Feb 2026 14:12:09 +0000 (UTC)
From: bot+bpf-ci@...nel.org
To: jolsa@...nel.org,andrii@...nel.org
Cc: bpf@...r.kernel.org,linux-kernel@...r.kernel.org,songliubraving@...com,yhs@...com,john.fastabend@...il.com,ast@...nel.org,andrii@...nel.org,daniel@...earbox.net,martin.lau@...nel.org,eddyz87@...il.com,yonghong.song@...ux.dev,clm@...a.com,ihor.solodrai@...ux.dev
Subject: Re: [PATCHv2 bpf-next 4/5] selftests/bpf: Add test for checking correct nop of optimized usdt

> diff --git a/tools/testing/selftests/bpf/prog_tests/usdt.c b/tools/testing/selftests/bpf/prog_tests/usdt.c
> --- a/tools/testing/selftests/bpf/prog_tests/usdt.c
> +++ b/tools/testing/selftests/bpf/prog_tests/usdt.c

[ ... ]

> +#ifdef __x86_64
          ^^^^^^^^
Should this be __x86_64__ (with trailing underscores) to match the standard
GCC predefined macro? The call site in test_usdt() uses __x86_64__:

> @@ -516,6 +599,8 @@ void test_usdt(void)
> #ifdef __x86_64__
> 	if (test__start_subtest("basic_optimized"))
> 		subtest_basic_usdt(true);
> +	if (test__start_subtest("optimized_attach"))
> +		subtest_optimized_attach();
> #endif

Without the trailing underscores, the function definition will not be
compiled on x86_64 while the call will be, leading to a linker error.


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/21867569087

AI-authorship-score: low
AI-authorship-explanation: The commit follows standard kernel selftest patterns with a natural coding style and contains a typo characteristic of human error rather than AI generation.
issues-found: 1
issue-severity-score: medium
issue-severity-explanation: The mismatched preprocessor macro will cause a linker error on x86_64 builds, preventing the test from compiling.