linux-kernel - Re: [PATCH] zram: drop slot trylock and miss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYtAz5vQTod7DXqV@casper.infradead.org>
Date: Tue, 10 Feb 2026 14:29:35 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Sergey Senozhatsky <senozhatsky@...omium.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Minchan Kim <minchan@...nel.org>, Brian Geffon <bgeffon@...gle.com>,
	Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org,
	linux-block@...r.kernel.org, linux-mm@...ck.org,
	Richard Chang <richardycc@...gle.com>,
	David Stevens <stevensd@...gle.com>
Subject: Re: [PATCH] zram: drop slot trylock and miss_free

On Tue, Feb 10, 2026 at 12:50:37PM +0900, Sergey Senozhatsky wrote:
> @@ -1943,15 +1927,9 @@ static ssize_t debug_stat_show(struct device *dev,
>  {
>  	int version = 1;
>  	struct zram *zram = dev_to_zram(dev);
> -	ssize_t ret;
>  
>  	guard(rwsem_read)(&zram->dev_lock);
> -	ret = sysfs_emit(buf,
> -			"version: %d\n0 %8llu\n",
> -			version,
> -			(u64)atomic64_read(&zram->stats.miss_free));
> -
> -	return ret;
> +	return sysfs_emit(buf, "version: %d\n0 0\n", version);
>  }

You don't need the dev_lock any more to just report the version.
And should the version be changed now that you've changed the format to
not include miss_free?