linux-kernel - Re: [PATCH] iio: frequency: adf4350: Return -ENOMEM on memory allocation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vdy=0+RF=4OSa-p_kkAkqqBZHOUv=nZ7sF3PjajfTr6mA@mail.gmail.com>
Date: Wed, 11 Feb 2026 19:39:43 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>
Cc: Marius Cristea <marius.cristea@...rochip.com>, Jonathan Cameron <jic23@...nel.org>, 
	David Lechner <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>, 
	Michael Hennerich <Michael.Hennerich@...log.com>, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: frequency: adf4350: Return -ENOMEM on memory
 allocation failure

On Wed, Feb 11, 2026 at 7:10 PM Antoniu Miclaus
<antoniu.miclaus@...log.com> wrote:
>
> adf4350_parse_dt() returns NULL only when devm_kzalloc() fails. The
> caller should return -ENOMEM in this case, not -EINVAL.

Right, and the memory allocator dumps enough info if it happens.
Reviewed-by: Andy Shevchenko <andy@...nel.org>

...

>                 pdata = dev_get_platdata(&spi->dev);

Side note: Have you considered killing legacy platform data?

-- 
With Best Regards,
Andy Shevchenko