linux-kernel - Re: [PATCH v6 1/4] tracing: Reset last_boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260211132848.2bda172a@fedora>
Date: Wed, 11 Feb 2026 13:28:48 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/4] tracing: Reset last_boot_info if ring buffer is
 reset

On Fri, 6 Feb 2026 22:50:51 +0900
Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:

> On Wed, 4 Feb 2026 20:40:49 -0500
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > On Sun,  1 Feb 2026 12:29:07 +0900
> > "Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:
> >   
> > > @@ -8036,6 +8042,7 @@ tracing_snapshot_write(struct file *filp, const char __user *ubuf, size_t cnt,
> > >  				tracing_reset_online_cpus(&tr->max_buffer);
> > >  			else
> > >  				tracing_reset_cpu(&tr->max_buffer, iter->cpu_file);
> > > +			update_last_data_if_empty(tr);  
> > 
> > Is this needed? Memory mapped buffers (which the persistent ring buffer
> > is) do not have snapshot buffers.  
> 
> Yeah, I did this just for consistency. But it is better to just leave
> the comment here.
> 

I have code to move all the snapshot buffers into its own file. I'm
going to drop this one as I think leaving it makes it more confusing.

-- Steve