linux-kernel - Re: [PATCH v5 1/4] mm: Add address apis for ptdescs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ead4a2d-c88c-4c89-b1dd-5954c28edb99@intel.com>
Date: Wed, 11 Feb 2026 12:13:10 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: "Vishal Moola (Oracle)" <vishal.moola@...il.com>,
 linux-kernel@...r.kernel.org, linux-mm@...ck.org, x86@...nel.org,
 "Mike Rapoport (Microsoft)" <rppt@...nel.org>
Cc: akpm@...ux-foundation.org, "Matthew Wilcox (Oracle)"
 <willy@...radead.org>, Dave Hansen <dave.hansen@...ux.intel.com>,
 Andy Lutomirski <luto@...nel.org>, Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH v5 1/4] mm: Add address apis for ptdescs

On 2/11/26 11:52, Vishal Moola (Oracle) wrote:
> +/**
> + * pgtable_alloc_addr - Allocate pagetables to get an address
> + * @gfp:       GFP flags
> + * @order:     desired pagetable order

FWIW, I don't like how pgtable_alloc_addr() looks in practice. It reads
like it is: "allocate a page table address", not "allocate a page
table". I don't have a better suggestion other than having:

	pgtable_alloc()

that returns a page table pointer, a void*, and:

	ptdesc_alloc()

which returns a ptdesc*. But I suspect that would get confusing at the
point that ptdescs _themselves_ start getting allocated.