linux-kernel - Re: [PATCH v7 1/4] dt-bindings: remoteproc: imx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260211205359.GA3857648-robh@kernel.org>
Date: Wed, 11 Feb 2026 14:53:59 -0600
From: Rob Herring <robh@...nel.org>
To: Shenwei Wang <shenwei.wang@....com>
Cc: Bartosz Golaszewski <brgl@...nel.org>, dl-linux-imx <linux-imx@....com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Linus Walleij <linusw@...nel.org>,
	"arnaud.pouliquen@...s.st.com" <arnaud.pouliquen@...s.st.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Shawn Guo <shawnguo@...nel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
	"linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
	Peng Fan <peng.fan@....com>, Conor Dooley <conor+dt@...nel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	Jonathan Corbet <corbet@....net>,
	Mathieu Poirier <mathieu.poirier@...aro.org>,
	Fabio Estevam <festevam@...il.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 1/4] dt-bindings: remoteproc: imx_rproc: Add "rpmsg"
 subnode support

On Wed, Feb 11, 2026 at 05:26:06PM +0000, Shenwei Wang wrote:
> 
> 
> > -----Original Message-----
> > From: Rob Herring (Arm) <robh@...nel.org>
> > Sent: Tuesday, February 10, 2026 2:48 PM
> > To: Shenwei Wang <shenwei.wang@....com>
> > Cc: Bartosz Golaszewski <brgl@...nel.org>; dl-linux-imx <linux-imx@....com>;
> > devicetree@...r.kernel.org; Linus Walleij <linusw@...nel.org>;
> > arnaud.pouliquen@...s.st.com; Krzysztof Kozlowski <krzk+dt@...nel.org>;
> > Sascha Hauer <s.hauer@...gutronix.de>; Shawn Guo <shawnguo@...nel.org>;
> > linux-gpio@...r.kernel.org; Bjorn Andersson <andersson@...nel.org>;
> > Pengutronix Kernel Team <kernel@...gutronix.de>; linux-arm-
> > kernel@...ts.infradead.org; linux-remoteproc@...r.kernel.org; Peng Fan
> > <peng.fan@....com>; Conor Dooley <conor+dt@...nel.org>;
> > imx@...ts.linux.dev; Jonathan Corbet <corbet@....net>; Mathieu Poirier
> > <mathieu.poirier@...aro.org>; Fabio Estevam <festevam@...il.com>; linux-
> > doc@...r.kernel.org; linux-kernel@...r.kernel.org
> > Subject: [EXT] Re: [PATCH v7 1/4] dt-bindings: remoteproc: imx_rproc: Add
> > "rpmsg" subnode support
> > 
> > On Tue, 10 Feb 2026 11:08:11 -0600, Shenwei Wang wrote:
> > > Remote processors may announce multiple GPIO controllers over an RPMSG
> > > channel. These GPIO controllers may require corresponding device tree
> > > nodes, especially when acting as providers, to supply phandles for
> > > their consumers.
> > >
> > > Define an RPMSG node to work as a container for a group of RPMSG
> > > channels under the imx_rproc node. Each subnode within "rpmsg"
> > > represents an individual RPMSG channel. The name of each subnode
> > > corresponds to the channel name as defined by the remote processor.
> > >
> > > All remote devices associated with a given channel are defined as
> > > child nodes under the corresponding channel node.
> > >
> > > Signed-off-by: Shenwei Wang <shenwei.wang@....com>
> > > ---
> > >  .../devicetree/bindings/gpio/gpio-rpmsg.yaml  | 55 +++++++++++++++++++
> > >  .../bindings/remoteproc/fsl,imx-rproc.yaml    | 53 ++++++++++++++++++
> > >  2 files changed, 108 insertions(+)
> > >  create mode 100644
> > > Documentation/devicetree/bindings/gpio/gpio-rpmsg.yaml
> > >
> > 
> > My bot found errors running 'make dt_binding_check' on your patch:
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > 
> > 
> > doc reference errors (make refcheckdocs):
> > Warning: Documentation/devicetree/bindings/gpio/gpio-rpmsg.yaml references
> > a file that doesn't exist: Documentation/driver-api/gpio/gpio-rpmsg.rst
> > Documentation/devicetree/bindings/gpio/gpio-rpmsg.yaml:
> > Documentation/driver-api/gpio/gpio-rpmsg.rst
> > 
> 
> The .rst file mentioned in the description is included in this same patch set.

Then can't the .rst doc come first?

Really, bindings should not reference kernel docs as they are used 
outside the kernel. However, since there is no other definition of the 
protocol, I think it is fine here.

Rob