linux-kernel - Re: [PATCH net-next] myri10ge: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <0244faa4-763c-4ccd-b98e-59a0ee6b346b@app.fastmail.com>
Date: Wed, 11 Feb 2026 22:07:56 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Jakub Kicinski" <kuba@...nel.org>, "Chen Ni" <nichen@...as.ac.cn>
Cc: andrew+netdev@...n.ch, "David S . Miller" <davem@...emloft.net>,
 "Eric Dumazet" <edumazet@...gle.com>, "Paolo Abeni" <pabeni@...hat.com>,
 "Ingo Molnar" <mingo@...nel.org>, "Thomas Gleixner" <tglx@...nel.org>,
 "Dave Jiang" <dave.jiang@...el.com>, "Lukas Wunner" <lukas@...ner.de>,
 Netdev <netdev@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] myri10ge: Convert comma to semicolon

On Wed, Feb 11, 2026, at 19:33, Jakub Kicinski wrote:
> On Tue, 10 Feb 2026 09:37:33 +0800 Chen Ni wrote:
>> Replace comma between expressions with semicolons.
>> 
>> Using a ',' in place of a ';' can have unintended side effects.
>> Although that is not the case here, it is seems best to use ';'
>> unless ',' is intended.
>> 

Fixes: fd24173439c0 ("myri10ge: avoid uninitialized variable use")
Acked-by: Arnd Bergmann <arnd@...db.de>

> ## Form letter - net-next-closed
>
> We have already submitted our pull request with net-next material for v7.0,
> and therefore net-next is closed for new drivers, features, code refactoring
> and optimizations. We are currently accepting bug fixes only.

This is a regression fix for a mistake I made in a patch you merged
for 7.0. This was not very clear since Chen forgot to add a 'Fixes'
tag and labeled it as [net-next] when it should (now) have been
[net].

     Arnd