linux-kernel - Re: [PATCH v2 2/2] gpio: aggregator: add gpio-aggregator DT compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADvTj4p-zHMrXW+GJstB2sKS-7Wij98JNJGoiPiYmaP5RHhNQg@mail.gmail.com>
Date: Wed, 11 Feb 2026 14:49:37 -0700
From: James Hilliard <james.hilliard1@...il.com>
To: Rob Herring <robh@...nel.org>
Cc: Bartosz Golaszewski <brgl@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org>, linux-gpio@...r.kernel.org, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Linus Walleij <linusw@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Alexander Stein <linux@...tq-group.com>, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] gpio: aggregator: add gpio-aggregator DT compatible

On Wed, Feb 11, 2026 at 2:47 PM Rob Herring <robh@...nel.org> wrote:
>
> On Wed, Feb 11, 2026 at 11:36:28AM +0100, Bartosz Golaszewski wrote:
> > On Wed, Feb 11, 2026 at 11:13 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> > >
> > > >>
> > > >>  static const struct of_device_id gpio_aggregator_dt_ids[] = {
> > > >> +       {
> > > >> +               .compatible = "gpio-aggregator",
> > > >> +       },
> > > >>         {
> > > >>                 .compatible = "gpio-delay",
> > > >>                 .data = (void *)FWD_FEATURE_DELAY,
> > > >> --
> > > >> 2.43.0
> > > >>
> > > >
> > > > Regardless of the DT bindings - this change is perfectly fine. We do
> > >
> > > You cannot have compatible without DT bindings, so this alone is not
> > > "perfectly fine". Maybe you wanted platform_device_id entry for
> > > ACPI/legacy/MFD devices?
> > >
> >
> > Sure you can, you just can't put it into upstream devicetree sources.
> > We have had a compatible for gpio-sim for testing purposes for years.
> > Why would it be illegal to enable matching of platform drivers over DT
> > for testing purposes?
>
> The primary issue is undocumented ones show up in 'make
> dt_compatible_check'. I would like that to be warning free.

Would adding it here make sense?
https://github.com/torvalds/linux/blob/v6.19/Documentation/devicetree/bindings/incomplete-devices.yaml#L243-L245

>
> Rob