linux-kernel - Re: [PATCH] staging: rtl8723bs: remove NDIS_802_11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DGBT9JBFPRLY.PQX59G71WEAM@gmail.com>
Date: Tue, 10 Feb 2026 21:26:44 -0600
From: "Ethan Tidmore" <ethantidmore06@...il.com>
To: "Ethan Luna" <trunixcodes@...omail.com>, <gregkh@...uxfoundation.org>
Cc: <linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: remove NDIS_802_11_RATES typedef

On Tue Feb 10, 2026 at 8:41 PM CST, Ethan Luna wrote:
> The kernel coding style discourages typedefs, especially those that hide
> array types. Remove the NDIS_802_11_RATES typedef and replace its users
> with explicit unsigned char arrays.
>
> No functional changes.
>
> Signed-off-by: Ethan Luna <trunixcodes@...omail.com>
> ---

You sent the exact same patch twice. As far as I can tell I don't see a
difference between them? However, had this been a revision, please only
send them every 24 hours.

>  drivers/staging/rtl8723bs/include/wlan_bssdef.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/wlan_bssdef.h b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> index eb38594c8f5c..6ad73d4de6bf 100644
> --- a/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> +++ b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> @@ -16,7 +16,7 @@
>  #define NDIS_802_11_LENGTH_RATES_EX     16
>  
>  typedef unsigned char   NDIS_802_11_MAC_ADDRESS[6];
> -typedef unsigned char   NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];        /*  Set of 8 data rates */
> +unsigned char   NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];        /*  Set of 8 data rates */
>  typedef unsigned char   NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];  /*  Set of 16 data rates */
>  
>  struct ndis_802_11_ssid {

By removing the typedef you made this a global char array, just remove
the line entirely. And actually replace the users of this typedef. Which
you said you did in your patch notes?

Thanks,

ET