linux-kernel - [PATCH v2 2/2] kho: remove unnecessary WARN_ON(err) in kho

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260211032937.208353-3-ranxiaokai627@163.com>
Date: Wed, 11 Feb 2026 03:29:37 +0000
From: ranxiaokai627@....com
To: graf@...zon.com,
	rppt@...nel.org,
	pasha.tatashin@...een.com,
	pratyush@...nel.org,
	akpm@...ux-foundation.org
Cc: kexec@...ts.infradead.org,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	ran.xiaokai@....com.cn,
	ranxiaokai627@....com
Subject: [PATCH v2 2/2] kho: remove unnecessary WARN_ON(err) in kho_populate()

From: Ran Xiaokai <ran.xiaokai@....com.cn>

The following pr_warn() provides detailed error and location
information, WARN_ON(err) adds no additional debugging value,
so remove the redundant WARN_ON() call.

Signed-off-by: Ran Xiaokai <ran.xiaokai@....com.cn>
Reviewed-by: Pratyush Yadav <pratyush@...nel.org>
Reviewed-by: Pasha Tatashin <pasha.tatashin@...een.com>
---
 kernel/liveupdate/kexec_handover.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c
index 3c705b08a489..eb87d23e8da6 100644
--- a/kernel/liveupdate/kexec_handover.c
+++ b/kernel/liveupdate/kexec_handover.c
@@ -1507,7 +1507,7 @@ void __init kho_populate(phys_addr_t fdt_phys, u64 fdt_len,
 
 		memblock_add(area->addr, size);
 		err = memblock_mark_kho_scratch(area->addr, size);
-		if (WARN_ON(err)) {
+		if (err) {
 			pr_warn("failed to mark the scratch region 0x%pa+0x%pa: %pe",
 				&area->addr, &size, ERR_PTR(err));
 			goto err_unmap_scratch;
-- 
2.25.1