lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <18e09860f731dd83c206e286f570ac77a5186ce9.camel@wdc.com>
Date: Wed, 11 Feb 2026 04:28:53 +0000
From: Wilfred Mallawa <wilfred.mallawa@....com>
To: "kbusch@...nel.org" <kbusch@...nel.org>, hch <hch@....de>,
	"axboe@...nel.dk" <axboe@...nel.dk>, "sagi@...mberg.me" <sagi@...mberg.me>,
	"linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: "dlemoal@...nel.org" <dlemoal@...nel.org>
Subject: Re: [PATCH v4] nvme/host: fixup some typos

On Wed, 2026-01-14 at 16:37 +1000, Wilfred Mallawa wrote:

Gentle ping, in-case this got lost in the threads :)

Wilfred

> From: Wilfred Mallawa <wilfred.mallawa@....com>
> 
> Fix up some minor typos/grammar in the nvme host tcp driver and a
> comment
> style to conform to the standard kernel style.
> 
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@....com>
> Reviewed-by: Damien Le Moal <dlemoal@...nel.org>
> Reviewed-by: Christoph Hellwig <hch@....de>
> ---
> V4:
> 	- Minor grammar fixup
> ---
>  drivers/nvme/host/tcp.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
> index 69cb04406b47..6658a5806dd9 100644
> --- a/drivers/nvme/host/tcp.c
> +++ b/drivers/nvme/host/tcp.c
> @@ -25,7 +25,8 @@
>  
>  struct nvme_tcp_queue;
>  
> -/* Define the socket priority to use for connections were it is
> desirable
> +/*
> + * Define the socket priority to use for connections where it is
> desirable
>   * that the NIC consider performing optimized packet processing or
> filtering.
>   * A non-zero value being sufficient to indicate general
> consideration of any
>   * possible optimization.  Making it a module param allows for
> alternative
> @@ -926,8 +927,9 @@ static int nvme_tcp_recv_data(struct
> nvme_tcp_queue *queue, struct sk_buff *skb,
>  			req->curr_bio = req->curr_bio->bi_next;
>  
>  			/*
> -			 * If we don`t have any bios it means that
> controller
> -			 * sent more data than we requested, hence
> error
> +			 * If we do not have any bios, it means that
> the
> +			 * controller sent more data than we
> requested,
> +			 * hence error
>  			 */
>  			if (!req->curr_bio) {
>  				dev_err(queue->ctrl->ctrl.device,

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ