linux-kernel - Re: [PATCH v2 1/2] dt-bindings: sound: simple-card: add sysclk-cpu-first flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4d3a008-bf9f-4a03-819d-c7a0afa1dbd1@kernel.org>
Date: Wed, 11 Feb 2026 07:23:12 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Stefano Radaelli <stefano.radaelli21@...il.com>,
 Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
 linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Mark Brown <broonie@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, alexander.h@...iscite.com,
 pierluigi.p@...iscite.com, Stefano Radaelli <stefano.r@...iscite.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: sound: simple-card: add
 sysclk-cpu-first flag

On 10/02/2026 17:45, Stefano Radaelli wrote:
> From: Stefano Radaelli <stefano.r@...iscite.com>
> 
> The simple-audio-card driver can program sysclk for CPU and codec DAIs
> during hw_params. Some setups require calling the CPU DAI sysclk first
> so that the codec sees the final MCLK rate.
> 
> Document a new boolean DT flag, sysclk-cpu-first, which allows selecting
> CPU-first sysclk ordering where needed. The property is supported both
> as a top-level simple-audio-card property (prefixed) and on dai-link
> subnodes (non-prefixed).

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.

> 
> Signed-off-by: Stefano Radaelli <stefano.r@...iscite.com>
> ---
>  .../devicetree/bindings/sound/simple-card.yaml        | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/simple-card.yaml b/Documentation/devicetree/bindings/sound/simple-card.yaml
> index 533d0a1da56e..ddad440636be 100644
> --- a/Documentation/devicetree/bindings/sound/simple-card.yaml
> +++ b/Documentation/devicetree/bindings/sound/simple-card.yaml
> @@ -35,6 +35,13 @@ definitions:
>      description: see tdm-slot.txt.
>      $ref: /schemas/types.yaml#/definitions/uint32
>  
> +  sysclk-cpu-first:
> +    description:
> +      When mclk-fs is used, configure CPU DAI sysclk before codec DAI sysclk
> +      so the codec sees the final MCLK rate.
> +      This property only affects the mclk-fs code path.

You described the desired Linux feature or behavior, not the actual
hardware. The bindings are about the latter, so instead you need to
rephrase the property and its description to match actual hardware
capabilities/features/configuration etc.

Best regards,
Krzysztof