[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+NOmzKaJPHpUZgUVWVKC72m=fCf5wBEsSErq+JmYNWHobax-g@mail.gmail.com>
Date: Wed, 11 Feb 2026 14:44:03 +0800
From: Yasin Lee <yasin.lee.x@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Jonathan Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>,
Nuno Sá <nuno.sa@...log.com>,
Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, yasin.lee.x@...look.com,
linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH 4/5] dt-bindings: iio: proximity: hx9023s: support
firmware-name property
On Mon, Feb 9, 2026 at 4:01 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On Mon, Feb 09, 2026 at 11:37:05AM +0800, Yasin Lee wrote:
> > Allow specifying the firmware file name via device tree.
>
> For what purpose? What's in the firmware?
>
Hi Krzysztof,
Thanks for the review.
The firmware contains device-specific configuration data required to
properly initialize the internal sensing engine of the hx9023s.
Although the silicon is identical, different board designs use different
electrode layouts and mechanical structures, which require different
calibration and register configuration tables for correct operation.
Without the appropriate configuration data, the sensor does not function
as intended on a given hardware design.
The default firmware name remains unchanged for existing platforms.
The firmware-name property is intended only to allow selecting the
correct hardware-specific configuration when the physical design differs.
Best regards,
Yasin Lee
> >
> > Signed-off-by: Yasin Lee <yasin.lee.x@...il.com>
> > ---
> > Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.yaml | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.yaml b/Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.yaml
> > index 64ce8bc8bd36..7e516fc011c6 100644
> > --- a/Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.yaml
> > +++ b/Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.yaml
> > @@ -28,6 +28,12 @@ properties:
> >
> > vdd-supply: true
> >
> > + firmware-name:
> > + description:
> > + Name of the firmware file to be requested by the driver using
> > + the firmware loader interface.
>
> Drop description, obvious. It cannot be anything else.
>
Agreed. Thanks.
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists