[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <92359c6d-06ac-4f8d-baa5-6fa45a536455@kernel.org>
Date: Wed, 11 Feb 2026 09:19:49 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: James Hilliard <james.hilliard1@...il.com>, linux-gpio@...r.kernel.org
Cc: Geert Uytterhoeven <geert+renesas@...der.be>,
Linus Walleij <linusw@...nel.org>, Bartosz Golaszewski <brgl@...nel.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Alexander Stein <linux@...tq-group.com>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: gpio: add gpio-aggregator binding
On 11/02/2026 09:17, Krzysztof Kozlowski wrote:
> On 11/02/2026 09:13, James Hilliard wrote:
>> Document the gpio-aggregator virtual GPIO controller with a dedicated
>> schema and compatible string.
>>
>> Also extend the GPIO AGGREGATOR MAINTAINERS entry to cover the new
>> binding file.
>
> <form letter>
> This is a friendly reminder during the review process.
>
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
>
> Thank you.
> </form letter>
>
First thing which was missing (I did not even check the rest in such
case): missing rationale for this patch, missing hardware description.
Best regards,
Krzysztof
Powered by blists - more mailing lists