linux-kernel - Re: [PATCH v8 3/8] irqchip/ls-extirq: Use for_each_of_imap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <zlgj2xi72amihcs3r3vzifci6hrce7rio4bqx23aet6bo2f624@2qnwemabjlql>
Date: Wed, 11 Feb 2026 12:03:00 +0200
From: Ioana Ciornei <ioana.ciornei@....com>
To: "Herve Codina (Schneider Electric)" <herve.codina@...tlin.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, 
	Wolfram Sang <wsa+renesas@...g-engineering.com>, Linus Walleij <linus.walleij@...aro.org>, 
	Bartosz Golaszewski <brgl@...ev.pl>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, 
	Saravana Kannan <saravanak@...nel.org>, linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	Pascal Eberhard <pascal.eberhard@...com>, Miquel Raynal <miquel.raynal@...tlin.com>, 
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v8 3/8] irqchip/ls-extirq: Use for_each_of_imap_item
 iterator

On Wed, Jan 14, 2026 at 10:39:32AM +0100, Herve Codina (Schneider Electric) wrote:
> The ls-extirq driver parses the interrupt-map property. It does it using
> open code.
> 
> Recently for_each_of_imap_item iterator has been introduce to help
> drivers in this parsing.
> 
> Convert the ls-extirq driver to use the for_each_of_imap_item
> iterator instead of open code.
> 

The ls-extirq uses interrupt-map but it's a non-standard use documented
in fsl,ls-extirq.yaml:

	# The driver(drivers/irqchip/irq-ls-extirq.c) have not use standard DT
	# function to parser interrupt-map. So it doesn't consider '#address-size'
	# in parent interrupt controller, such as GIC.
	#
	# When dt-binding verify interrupt-map, item data matrix is spitted at
	# incorrect position. Remove interrupt-map restriction because it always
	# wrong.

This means that by using for_each_of_imap_item and the underlying
of_irq_parse_imap_parent() on its interrupt-map property will
effectively break its functionality.

Unfortunatelly, I am not sure how this can be fixed other than with a
revert.

Ioana