linux-kernel - Re: [PATCH v7 1/2] net: mhi: Enable Ethernet interface support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d24a947d-6b6e-4393-b0b6-1e9281f8a0cb@oss.qualcomm.com>
Date: Wed, 11 Feb 2026 15:54:59 +0530
From: vivek pernamitta <vivek.pernamitta@....qualcomm.com>
To: Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Manivannan Sadhasivam <mani@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, mhi@...ts.linux.dev,
        linux-arm-msm@...r.kernel.org,
        Vivek Pernamitta <vpernami@....qualcomm.com>
Subject: Re: [PATCH v7 1/2] net: mhi: Enable Ethernet interface support



On 2/10/2026 4:13 PM, Paolo Abeni wrote:
> On 2/5/26 11:34 AM, Vivek Pernamitta wrote:
>> @@ -4,6 +4,7 @@
>>    * Copyright (C) 2020 Linaro Ltd <loic.poulain@...aro.org>
>>    */
>>   
>> +#include <linux/etherdevice.h>
>>   #include <linux/if_arp.h>
>>   #include <linux/mhi.h>
>>   #include <linux/mod_devicetable.h>
>> @@ -38,10 +39,12 @@ struct mhi_net_dev {
>>   	u32 rx_queue_sz;
>>   	int msg_enable;
>>   	unsigned int mru;
>> +	bool ethernet_if;
> 
> This is not needed, instead you could check !!dev->header_ops
> 
> /P
> 

As this driver supports only Ethernet and IP net interface types.
Will remove the ethernet_if member from the mhi_net_dev structure
and use net_device->header_ops for interface-type checks