linux-kernel - Re: [PATCH net-next v2] docs: ethtool: clarify the bit-by-bit bitset format description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2882370-a531-4a83-ab39-cf73878c0d03@redhat.com>
Date: Wed, 11 Feb 2026 12:55:55 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Yohei Kojima <yk@...oj.net>, Andrew Lunn <andrew@...n.ch>,
 Jakub Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Simon Horman <horms@...nel.org>,
 Jonathan Corbet <corbet@....net>
Cc: netdev@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] docs: ethtool: clarify the bit-by-bit bitset
 format description

On 2/7/26 11:25 AM, Yohei Kojima wrote:
> Clarify the bit-by-bit bitset format's behavior around mandatory
> attributes and bit identification. More specifically, the following
> changes are made:
> 
> * Rephrase a misleading sentence which implies name and index are
>   mutually exclusive
> * Describe that ETHTOOL_A_BITSET_BITS nest is mandatory
> * Describe that a request fails if inconsistent identifiers are given
> 
> Signed-off-by: Yohei Kojima <yk@...oj.net>
> ---
> Current ethtool-netlink documentation doesn't describe several behavior
> around bit-by-bit bitset, which makes it hard to develop a ethtool
> library without digging into the kernel code. This patch eases the gap
> between the kernel behavior and the documentation by adding descriptions
> around the mandatory attribute and bit identification.

This needs review by someone provided with English natural language
skills far better than mine. I'm wrapping the net-next PR right now;
this has to be deferred after the merge window, I'm sorry.

/P