linux-kernel - Re: [PATCH v3] apple-gmux: preserve brightness using EFI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260211123018.4910-1-atharvatiwarilinuxdev@gmail.com>
Date: Wed, 11 Feb 2026 18:00:18 +0530
From: Atharva Tiwari <atharvatiwarilinuxdev@...il.com>
To: hansg@...nel.org
Cc: atharvatiwarilinuxdev@...il.com,
	ilpo.jarvinen@...ux.intel.com,
	linux-kernel@...r.kernel.org,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v3] apple-gmux: preserve brightness using EFI

> I think this is missing efivar_lock() + unlock() calls ?

actually, efivar_set_variable already holds the lock, so efivar_lock isint
required.

See: drivers/firmware/efi/vars.c:242 and drivers/firmware/efi/vars.c:184