linux-kernel - Re: [PATCH v9 12/21] wifi: nxpwifi: introduce command and event handling infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYyDdAmlvI2TqNA0@nxpwireless-Inspiron-14-Plus-7440>
Date: Wed, 11 Feb 2026 21:26:12 +0800
From: Jeff Chen <jeff.chen_1@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	briannorris@...omium.org, johannes@...solutions.net,
	francesco@...cini.it, s.hauer@...gutronix.de
Subject: Re: [PATCH v9 12/21] wifi: nxpwifi: introduce command and event
 handling infrastructure

On Wed, Feb 11, 2026 at 10:39:03 AM +0100, Krzysztof Kozlowski wrote:
> On 04/02/2026 19:03, Jeff Chen wrote:
> > +
> > +		/*
> > +		 * Download calibration data to firmware.
> > +		 * The cal-data can be read from device tree and/or
> > +		 * a configuration file and downloaded to firmware.
> > +		 */
> > +		if (adapter->dt_node) {
> > +			if (of_property_read_u32(adapter->dt_node,
> > +						 "nxp,wakeup-pin",
> 
> Don't sneak in ABI. This is not acceptable.
> 
> NAK
> 
> 
> Best regards,
> Krzysztof
> 

Acknowledged. This was not intentional — the DT property access was left
over from earlier bring-up work and should not appear in the upstream
submission without a proper binding. Thanks for pointing this out; I will
correct it in the next revision.

regards,
jeff