linux-kernel - Re: [PATCH v4 07/11] iio: amplifiers: ad8366: refactor device resource management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYyEhGWhql7C78PY@smile.fi.intel.com>
Date: Wed, 11 Feb 2026 15:30:44 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Rodrigo Alencar <455.rodrigo.alencar@...il.com>
Cc: rodrigo.alencar@...log.com, linux-kernel@...r.kernel.org,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v4 07/11] iio: amplifiers: ad8366: refactor device
 resource management

On Wed, Feb 11, 2026 at 12:10:11PM +0000, Rodrigo Alencar wrote:
> On 26/02/10 10:05PM, Andy Shevchenko wrote:
> > On Tue, Feb 10, 2026 at 07:42:07PM +0000, Rodrigo Alencar via B4 Relay wrote:
> > 
> > > Adhere modern device resource management with the following:
> > > - Voltage regulator managed and enabled internally;
> > > - IIO device registration handled with devm_iio_device_register();
> > > - removal of goto's from the probe function;
> > > - ad8366_remove() removed as it is not needed anymore;
> > > 
> > > With the drop of goto's dev_err_probe() is used to report probe errors.
> > 
> > I think the regulator change should be split and go before the previous patch,
> > because that one affects the ordering in the error path and remove stage.
> 
> OK, that can be done, but the same way,
> the error check would change as well as the dev_err_probe() args, not seeing
> much benefit there as the same lines will have to be touched anyways.

The point is to range the problems and target the more serious one first.
I consider the wrong ordering, (mis)use of devm_*() are in a priority to
just a simple cleanup.

-- 
With Best Regards,
Andy Shevchenko