netdev - Re: [SAA9730] Fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061129044428.GF15364@stusta.de>
Date:	Wed, 29 Nov 2006 05:44:28 +0100
From:	Adrian Bunk <bunk@...sta.de>
To:	Ralf Baechle <ralf@...ux-mips.org>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Jeff Garzik <jeff@...zik.org>, netdev@...r.kernel.org
Subject: Re: [SAA9730] Fix build error

On Tue, Nov 28, 2006 at 05:32:59PM +0000, Ralf Baechle wrote:
> Confusingly NET_PCI is also set for for non-PCI EISA configurations where
> building this driver will result in a build error due to a reference to
> pci_release_regions.
> 
> While at it, remove the EXPERIMENTAL - in all its uglyness and despite

Please also remove the EXPERIMENTAL from the help text.

> the sincerest attempts of the buggy hardware the driver is known to work
> and limit the driver to the Atlas board - the only known system to ever
> use the SAA9730 before Phillips ended the short live of the SAA9730.
> 
> Signed-off-by: Ralf Baechle <ralf@...ux-mips.org>
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 4f22c8e..6b5b745 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -1762,7 +1762,7 @@ config VIA_RHINE_NAPI
>  
>  config LAN_SAA9730
>  	bool "Philips SAA9730 Ethernet support (EXPERIMENTAL)"
> -	depends on NET_PCI && EXPERIMENTAL && MIPS
> +	depends on NET_PCI && PCI && MIPS_ATLAS
>  	help
>  	  The SAA9730 is a combined multimedia and peripheral controller used
>  	  in thin clients, Internet access terminals, and diskless

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html