lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Nov 2006 14:55:11 +0100 From: Thomas Graf <tgraf@...g.ch> To: davem@...emloft.net Cc: netdev@...r.kernel.org Subject: [IPv4] fib: Fix out of bound access of fib_props[] Fixes a typo which caused fib_props[] to have the wrong size and makes sure the value used to index the array which is provided by userspace via netlink is checked to avoid out of bound access. Signed-off-by: Thomas Graf <tgraf@...g.ch> Index: net-2.6/net/ipv4/fib_semantics.c =================================================================== --- net-2.6.orig/net/ipv4/fib_semantics.c 2006-11-29 13:33:05.000000000 +0100 +++ net-2.6/net/ipv4/fib_semantics.c 2006-11-29 13:36:13.000000000 +0100 @@ -89,7 +89,7 @@ { int error; u8 scope; -} fib_props[RTA_MAX + 1] = { +} fib_props[RTN_MAX + 1] = { { .error = 0, .scope = RT_SCOPE_NOWHERE, @@ -658,6 +658,9 @@ struct fib_info *ofi; int nhs = 1; + if (cfg->fc_type > RTN_MAX) + goto err_inval; + /* Fast check to catch the most weird cases */ if (fib_props[cfg->fc_type].scope > cfg->fc_scope) goto err_inval; - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists