netdev - Re: [PATCH] d80211: Reset assoc and auth retry counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a32f33a40611290627q5fb9f905ued49bbae6f5670b3@mail.gmail.com>
Date:	Wed, 29 Nov 2006 15:27:06 +0100
From:	"Ivo Van Doorn" <ivdoorn@...il.com>
To:	"Jiri Benc" <jbenc@...e.cz>
Cc:	"John Linville" <linville@...driver.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] d80211: Reset assoc and auth retry counters

On 11/29/06, Jiri Benc <jbenc@...e.cz> wrote:
> On Tue, 28 Nov 2006 20:56:05 +0100, Ivo van Doorn wrote:
> > After a succesfull authentication and association the matching retry
> counter
> > must be reset to 0.
> > Failure to do so will result in failure to authenticate after the
> interface
> > has been deauthenticated. This does not always happen after the first
> > deauthentication, but after the interface has been several times been
> > deauthenticated it will refuse to authenticate.
>
> Thanks for spotting this, but your fix makes statistics about
> authentication/association exported via sysfs useless. The counters
> should be reset before a new authentication/association attempt (as is
> done in ieee80211_sta_new_auth).

Sounds good to me, I was unsure where those counters should be reset anyway. :)

> I think this is a more correct fix:
> @@ -2858,7 +2866,7 @@ int ieee80211_sta_deauthenticate(struct
>  		return -EINVAL;
>
>  	ieee80211_send_deauth(dev, ifsta, reason);
> -	ieee80211_set_associated(dev, ifsta, 0);
> +	ieee80211_set_disassoc(dev, ifsta, 1);
>  	return 0;
>  }
>
> @@ -2878,6 +2886,6 @@ int ieee80211_sta_disassociate(struct ne
>  		return -1;
>
>  	ieee80211_send_disassoc(dev, ifsta, reason);
> -	ieee80211_set_associated(dev, ifsta, 0);
> +	ieee80211_set_disassoc(dev, ifsta, 1);
>  	return 0;
>  }
>

Shouldn't this last one be:
ieee80211_set_disassoc(dev, ifsta, 0)

This one is called from the IOCTL request to dissassociate,
so the interface should still be authenticated (with a valid
auth retry counter).

Ivo
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html