netdev - Re: [NET_SCHED 01/06]: sch_htb: perform qlen adjustment immediately in ->delete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 29 Nov 2006 17:35:01 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	devik@....cz, netdev@...r.kernel.org
Subject: Re: [NET_SCHED 01/06]: sch_htb: perform qlen adjustment
 immediately in ->delete

From: Patrick McHardy <kaber@...sh.net>
Date: Mon, 20 Nov 2006 14:08:37 +0100 (MET)

> [NET_SCHED]: sch_htb: perform qlen adjustment immediately in ->delete
> 
> qlen adjustment should happen immediately in ->delete and not in the
> class destroy function because the reference count will not hit zero in
> ->delete (sch_api holds a reference) but in ->put. Since the qdisc
> lock is released between deletion of the class and final destruction
> this creates an externally visible error in the qlen counter.
> 
> Signed-off-by: Patrick McHardy <kaber@...sh.net>

Applied to net-2.6.20
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html