netdev - Re: pktgen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6fcc0a0611292330n42fb1485h59804cc94a332f19@mail.gmail.com>
Date:	Thu, 30 Nov 2006 10:30:45 +0300
From:	"Alexey Dobriyan" <adobriyan@...il.com>
To:	"David Miller" <davem@...emloft.net>
Cc:	pavol.gono@...il.com, netdev@...r.kernel.org
Subject: Re: pktgen

On 11/30/06, David Miller <davem@...emloft.net> wrote:
> From: Alexey Dobriyan <adobriyan@...il.com>
> Date: Wed, 29 Nov 2006 23:04:37 +0300
>
> > Looks like worker thread strategically clears it if scheduled at wrong
> > moment.
> >
> > --- a/net/core/pktgen.c
> > +++ b/net/core/pktgen.c
> > @@ -3292,7 +3292,6 @@ static void pktgen_thread_worker(struct
> >
> >  	init_waitqueue_head(&t->queue);
> >
> > -	t->control &= ~(T_TERMINATE);
> >  	t->control &= ~(T_RUN);
> >  	t->control &= ~(T_STOP);
> >  	t->control &= ~(T_REMDEVALL);
>
> Good catch Alexey.  Did you rerun the load/unload test with
> this fix applied?  If it fixes things, I'll merge it.

Well, yes, it fixes things, except Ctrl+C getting you out of
modprobe/rmmod loop will spit
backtrace again. And other flags: T_RUN, T_STOP. Clearance is not
needed due to kZalloc and
create bugs as demostrated.

Give me some time.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html