| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <456F15F7.3000700@candelatech.com> Date: Thu, 30 Nov 2006 09:33:43 -0800 From: Ben Greear <greearb@...delatech.com> To: Robert Olsson <Robert.Olsson@...a.slu.se> CC: Alexey Dobriyan <adobriyan@...il.com>, David Miller <davem@...emloft.net>, pavol.gono@...il.com, netdev@...r.kernel.org Subject: Re: pktgen Robert Olsson wrote: > Hello! > > Seems you found a race when rmmod is done before it's fully started > > Try: > > diff --git a/net/core/pktgen.c b/net/core/pktgen.c > index 733d86d..ac0b4b1 100644 > --- a/net/core/pktgen.c > +++ b/net/core/pktgen.c > @@ -160,7 +160,7 @@ > #include <asm/div64.h> /* do_div */ > #include <asm/timex.h> > > -#define VERSION "pktgen v2.68: Packet Generator for packet performance testing.\n" > +#define VERSION "pktgen v2.69: Packet Generator for packet performance testing.\n" > > /* #define PG_DEBUG(a) a */ > #define PG_DEBUG(a) > @@ -3673,6 +3673,8 @@ static void __exit pg_cleanup(void) > struct list_head *q, *n; > wait_queue_head_t queue; > init_waitqueue_head(&queue); > + > + schedule_timeout_interruptible(msecs_to_jiffies(125)); > > /* Stop all interfaces & threads */ > > That strikes me as a hack..surely there is a better method than just adding a sleep?? Ben -- Ben Greear <greearb@...delatech.com> Candela Technologies Inc http://www.candelatech.com - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists