netdev - Re: [PATCH 2/5] NetXen: temp monitoring, newer firmware support, mm footprint reduction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061130191311.4d9ba296@localhost.localdomain>
Date:	Thu, 30 Nov 2006 19:13:11 -0800
From:	Stephen Hemminger <shemminger@...l.org>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	Don Fry <brazilnut@...ibm.com>, netdev@...r.kernel.org,
	amitkale@...xen.com, jeff@...zik.org, netxenproj@...syssoft.com,
	rob@...xen.com, sanjeev@...xen.com, wendyx@...ibm.com
Subject: Re: [PATCH 2/5] NetXen: temp monitoring, newer firmware support, mm
 footprint reduction


> > @@ -869,7 +937,10 @@ static inline void netxen_nic_disable_in
> >  	/*
> >  	 * ISR_INT_MASK: Can be read from window 0 or 1.
> >  	 */
> > -	writel(0x7ff, (void __iomem *)(adapter->ahw.pci_base + ISR_INT_MASK));
> > +	writel(0x7ff,
> > +	       (void __iomem
> > +		*)(PCI_OFFSET_SECOND_RANGE(adapter, ISR_INT_MASK)));
> > +
> 
> Yuck

If pci_base were correctly typed __iomem the casting would not
be needed.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html