[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20061201.202156.89126262.davem@davemloft.net>
Date: Fri, 01 Dec 2006 20:21:56 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: Kim.Nordlund@...ia.com
Cc: kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PKT_SCHED] act_gact: division by zero
From: "Nordlund Kim (Nokia-NET/Helsinki)" <Kim.Nordlund@...ia.com>
Date: Thu, 30 Nov 2006 15:51:04 +0200 (EET)
>
> On Thu, 30 Nov 2006, ext Patrick McHardy wrote:
> > I think it should reject an invalid configuration or handle
> > the zero case correctly by not dividing.
>
> You are correct. Not returning -EINVAL, because someone might
> want to use the value zero in some future gact_prob algorithm?
>
> Signed-off-by: Kim Nordlund <kim.nordlund@...ia.com>
Applied, thanks Kim.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists