netdev - Re: zd1211 ported to Devicescape stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061202132539.GB18326@p15091797.pureserver.info>
Date:	Sat, 2 Dec 2006 14:25:39 +0100
From:	Ulrich Kunitz <kune@...ne-taler.de>
To:	Michael Wu <flamingice@...rmilk.net>
Cc:	Daniel Drake <dsd@...too.org>, netdev@...r.kernel.org,
	John Linville <linville@...driver.com>,
	Luis Rodriguez <mcgrof@...il.com>
Subject: Re: zd1211 ported to Devicescape stack

Hi Michael,

> 	I have finished a port of the zd1211 driver to the Devicescape 802.11 stack. 

This is absolutely great news. I will look into it and check it
today.

> 	- The original driver does not seem to check if a frame has been successfully 
> TXed (as in RXed an ACK), so the port does not properly report to the stack 
> whether or not a TX succeeded.

TX is atomic. Do you really want to spin for the received ACK? Layer 2 doesn't
need to make any guarantees for packet transmission, so I have
trouble to see the point here. The Linux Device Driver book says
explicitly that packet transmission must not have been completed
at the point in time the function returns.

> 	-Because d80211 does not have complete regulatory domains support yet, the 
> associated code was trimmed to the bare minimum of reading the region code. 

I have to look into it, but the code we had, didn't rely on upper
layer support. I would suggest to maintain it until d80211 has
complete regulatory domains support.

> 	- The LED link status isn't too reliable - I haven't found a way to reliably 
> tell if the upper layer thinks it is associated, and I don't know how to use 
> the LED api. Not too worried about this issue though.

It took us also some time to do it for softmac. But it appears
that the d80211 stack needs still a fair amount of work.

-- 
Uli Kunitz
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html