netdev - Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061204100124.619de892@freekitty>
Date:	Mon, 4 Dec 2006 10:01:24 -0800
From:	Stephen Hemminger <shemminger@...l.org>
To:	Andrew Victor <andrew@...people.com>
Cc:	netdev@...r.kernel.org, jgarzik@...ox.com
Subject: Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 2

On 04 Dec 2006 14:42:08 +0200
Andrew Victor <andrew@...people.com> wrote:

> This patch adds NetPoll / NetConsole support to the Atmel AT91RM9200
> Ethernet driver.
> 
> Original patch from Bill Gatliff.
> 
> 
> Signed-off-by: Andrew Victor <andrew@...people.com>
> 
> 
> diff -urN linux-2.6.19-final.orig/drivers/net/arm/at91_ether.c linux-2.6.19-final/drivers/net/arm/at91_ether.c
> --- linux-2.6.19-final.orig/drivers/net/arm/at91_ether.c	Mon Dec  4 14:27:21 2006
> +++ linux-2.6.19-final/drivers/net/arm/at91_ether.c	Mon Dec  4 14:33:35 2006
> @@ -925,6 +925,17 @@
>  	return IRQ_HANDLED;
>  }
>  
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> +static void at91ether_poll_controller(struct net_device *dev)
> +{
> +	unsigned long flags;
> +
> +	local_irq_save(flags);
> +	at91ether_interrupt(dev->irq, dev, NULL);
> +	local_irq_restore(flags);
> +}
> +#endif

poll_controller is always called with interrupts already disabled.

The third argument to interrupt routines was dropped (struct pt_regs) in 2.6.19.
Maybe that never got fixed in ARM?

-- 
Stephen Hemminger <shemminger@...l.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html