netdev - [patch] Fix SNMPv2 "ipOutNoRoutes" counter error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1165337386.2545.4.camel@LINE>
Date:	Tue, 05 Dec 2006 11:49:46 -0500
From:	weidong <weid@...jing-fnst.com>
To:	netdev@...r.kernel.org
Subject: [patch] Fix SNMPv2 "ipOutNoRoutes" counter error

Hi All:
    When I tested linux kernel 2.6.18.3, and find that kernel statistics
about IPSTATS_MIB_OUTNOROUTES which exsits in file /proc/net/snmp
doesn't increase correctly.  The criteria conform to RFC2011:

  ipOutNoRoutes OBJECT-TYPE
    SYNTAX      Counter32
    MAX-ACCESS  read-only
    STATUS      current
    DESCRIPTION
            "The number of IP datagrams discarded because no route could
            be found to transmit them to their destination.  Note that
            this counter includes any packets counted in ipForwDatagrams
            which meet this `no-route' criterion.  Note that this
            includes any datagrams which a host cannot route because all
            of its default routers are down."
    ::= { ip 12 }

When a host received an IP packet, but the destination address is not
this host. The kernel just discards the IP packet but with no increment
for this counter.

When a router received an IP packet that this router can't forward due
to no route found. Kernel just simply invoke ip_error(), and send ICMP
packet. Also do nothing for this counter.

Signed-off-by: Wei Dong <weid@...jing-fnst.com>

diff -ruN old/net/ipv4/icmp.c new/net/ipv4/icmp.c
--- old/net/ipv4/icmp.c	2006-09-20 00:42:06.000000000 -0300
+++ new/net/ipv4/icmp.c	2006-12-04 11:46:39.000000000 -0300
@@ -580,6 +580,9 @@
 		icmp_param.data_len = room;
 	icmp_param.head_len = sizeof(struct icmphdr);
 
+	if (code == ICMP_NET_UNREACH)
+		IP_INC_STATS_BH(IPSTATS_MIB_OUTNOROUTES);
+
 	icmp_push_reply(&icmp_param, &ipc, rt);
 ende:
 	ip_rt_put(rt);
diff -ruN old/net/ipv4/ip_input.c new/net/ipv4/ip_input.c
--- old/net/ipv4/ip_input.c	2006-09-20 00:42:06.000000000 -0300
+++ new/net/ipv4/ip_input.c	2006-11-29 11:15:52.000000000 -0300
@@ -340,8 +340,10 @@
 		int err = ip_route_input(skb, iph->daddr, iph->saddr, iph->tos,
 					 skb->dev);
 		if (unlikely(err)) {
-			if (err == -EHOSTUNREACH)
+			if (err == -EHOSTUNREACH) {
 				IP_INC_STATS_BH(IPSTATS_MIB_INADDRERRORS);
+				IP_INC_STATS_BH(IPSTATS_MIB_OUTNOROUTES);
+			}
 			goto drop; 
 		}
 	}


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html