netdev - Re: RFC: consistent disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <457454CF.7040308@trash.net>
Date:	Mon, 04 Dec 2006 18:03:11 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Alexey Kuznetsov <kuznet@....inr.ac.ru>
CC:	James Morris <jmorris@...ei.org>,
	Linux Netdev List <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: RFC: consistent disable_xfrm behaviour

Alexey Kuznetsov wrote:
> Hello!
> 
> 
>>Alexey, do you remember what the original intent of this was?
> 
> 
> disable_policy was supposed to skip policy checks on input.
> It makes sense only on input device.
> 
> disable_xfrm was supposed to skip transformations on output.
> It makes sense only on output device.
> 
> If it does not work, it was done wrong. :-)
> 
> As I see it, root of the problem is that DST_NOXFRM flag
> is calculated using wrong device. out_dev should be used
> in __mkroute_input(). It looks as a cut-n-paste error, the code
> was taken from output path, where it is correct.

Thanks, thats exactly what I suspected :)

Here's the patch again properly signed off.




View attachment "x" of type "text/plain" (975 bytes)