netdev - Re: [PATCH 10/10] chelesio: transmit locking (plus bug fix).

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061204095828.0e50f359@freekitty>
Date:	Mon, 4 Dec 2006 09:58:28 -0800
From:	Stephen Hemminger <shemminger@...l.org>
To:	"Eric Lemoine" <eric.lemoine@...il.com>
Cc:	"Jeff Garzik" <jgarzik@...ox.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 10/10] chelesio: transmit locking (plus bug fix).

On Sun, 3 Dec 2006 11:45:09 +0100
"Eric Lemoine" <eric.lemoine@...il.com> wrote:

> Stephen,
> 
> On 12/2/06, Stephen Hemminger <shemminger@...l.org> wrote:
> > If transmit lock is contended on, then push return code back
> > and retry at higher level.
> 
> Looking at qdisc_restart, it seems to me that the NETDEV_TX_LOCKED
> return code must only be used if the device features LLTX. With your
> patch, if q->lock is already grabbed, qdisc_restart is going to
> requeue skb without going through the collision section of
> qdisc_restart.
>
The Chelsio driver already sets LLTX (see drivers/net/chelsio/cxgb2.c)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html